chore: Conditionally mark repo rules as reproducible#123
Merged
alexeagle merged 1 commit intobazel-contrib:mainfrom Mar 10, 2026
Merged
chore: Conditionally mark repo rules as reproducible#123alexeagle merged 1 commit intobazel-contrib:mainfrom
alexeagle merged 1 commit intobazel-contrib:mainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f555c72ae0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
alexeagle
approved these changes
Feb 19, 2026
mortenmj
force-pushed
the
mmj/reproducible
branch
from
b5f3263 to
256df82
Compare
alexeagle
approved these changes
Feb 23, 2026
alexeagle
reviewed
Feb 23, 2026
alexeagle
left a comment
alexeagle
left a comment
There was a problem hiding this comment.
CI failure looks legit
ERROR: /tmp/tmp.TOGrl7N4p8/external/rules_multitool~/multitool/private/multitool.bzl:172:46: name 'reproducible' is not defined
ERROR: Error computing the main repository mapping: at /tmp/tmp.TOGrl7N4p8/external/rules_multitool~/multitool/multitool.bzl:3:6: compilation of module 'multitool/private/multitool.bzl' failed
34433a3 to
259298b
Compare
mortenmj
changed the title
Contributor
Author
|
@alexeagle I've updated the PR, and ran build/test locally. Could you trigger another CI run? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows external dependencies created by rules_multitool to use the remote repo content cache.
If there are cases where these repo rules are not reproducible (e.g. if the sha256 is optional), we should account for that. I'd appreciate feedback on this as part of the review.